Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-3803 Modified cfbs add folder behavior #30

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Oct 18, 2021

Folder is searched recursively.
All .cf files are added to inputs.
Any def.json files are merged into top-level def.json.
All files are copied to services/cfbs/.

Ticket: CFE-3803

@craigcomstock craigcomstock marked this pull request as draft October 18, 2021 21:56
@cf-bottom
Copy link

Thank you for submitting a PR! Maybe @vpodzime can review this?

@craigcomstock craigcomstock marked this pull request as ready for review October 20, 2021 19:35
@craigcomstock craigcomstock changed the title ENT-7663 Modified cfbs add folder behavior CFE-3803 Modified cfbs add folder behavior Oct 20, 2021
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise.

cfbs/commands.py Outdated Show resolved Hide resolved
cfbs/commands.py Outdated Show resolved Hide resolved
cfbs/index.py Outdated Show resolved Hide resolved
cfbs/index.py Outdated Show resolved Hide resolved
cfbs/commands.py Outdated Show resolved Hide resolved
test/test_showinfo.py Outdated Show resolved Hide resolved
@craigcomstock
Copy link
Contributor Author

@vpodzime let me know how this looks and I'll squash commits.

Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please squash the commits and feel free to merge this.

Folder is searched recursively.
All .cf files are added to inputs.
Any def.json files are merged into top-level def.json.
All files are copied to services/cfbs/<modulename>.

Ticket: CFE-3803
@craigcomstock craigcomstock merged commit 180a02f into cfengine:master Oct 22, 2021
@craigcomstock craigcomstock deleted the ENT-7663 branch October 22, 2021 16:12
craigcomstock added a commit to craigcomstock/build-index that referenced this pull request Oct 22, 2021
This commit includes cfengine/masterfiles@a371c3a and so enables recent "add directory" changes cfengine/cfbs#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants