Download modules from our mirror instead of cloning #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning the repositories with modules is not a good idea, especially because the repositories can be deleted by their owners or some other issues can happen. Instead, when a module is added to the index, we archive it in our mirror and then use the archive in `cfbs build`, verifying that the checksum matches the expected value stored in cfbs-index/master/versions.json. Ticket: CFE-3780 Changelog: 'cfbs build' now downloads module archives instead of cloning repositories
vpodzime
force-pushed
the
master-download_from_mirror
branch
2 times, most recently
from
4e213a3
to
6af1fbc
Compare
And thus in 'cfbs show' or 'cfbs info'. It's a useful piece of information.
vpodzime
force-pushed
the
master-download_from_mirror
branch
from
6af1fbc
to
4523c1a
Compare
olehermanse
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning the repositories with modules is not a good idea,
especially because the repositories can be deleted by their
owners or some other issues can happen. Instead, when a module is
added to the index, we archive it in our mirror and then use the
archive in
cfbs build, verifying that the checksum matches theexpected value stored in cfbs-index/master/versions.json.
Ticket: CFE-3780
Changelog: 'cfbs build' now downloads module archives instead of cloning repositories