CFE-4244: Add the function name to the result cache key #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
force-pushed
the
function-name-cache
branch
from
440caa0 to
8db5f62
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amousset
changed the title
amousset
force-pushed
the
function-name-cache
branch
2 times, most recently
from
781663b to
4fbabae
Compare
|
The acceptance test fails on Windows: Maybe a difference in the way dns resolution is implemented. I will try to find a safer test case. |
larsewi
force-pushed
the
function-name-cache
branch
from
8ad317d to
690a0c5
Compare
amousset
commented
Sep 13, 2023
|
Tried a third attempt to create an acceptance test. Let me know what you think @amousset |
larsewi
force-pushed
the
function-name-cache
branch
from
9fb4837 to
57dcd13
Compare
|
@amousset, let me know if you agree with the changes I made :) |
larsewi
added
the
cherry-pick?
|
Looks good 👍 |
The function cache only used the args values, which in some cases could lead to mixing results from different functions with the same arguments. Ticket: CFE-4244 Changelog: Cashed policy function results now take into account number of arguments and function name. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> Co-authored-by: Alexis Mousset <alexis.mousset@rudder.io>
larsewi
force-pushed
the
function-name-cache
branch
from
57dcd13 to
29e60a9
Compare
|
Squashed the commits. Please ACK if you agree with the results @amousset :) |
yes 👍 |
|
@cf-bottom can you run this through Jenkins please? |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9818/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9818/ |
This was referenced Sep 14, 2023
larsewi
previously approved these changes
Sep 14, 2023
Two reasons for this: 1. CONTRIBUTING.md says to do this at the top 2. the `ctx` argument was actually used before the assert Ticket: None Changelog: None Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
|
Thanks for your contribution @amousset 🚀 |
larsewi
removed
the
cherry-pick?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function cache only used the args values as key, which in some cases could lead to mixing results from different functions with the same arguments.
Related to #5313.