Add missing #include's previously pulled in by libntech #5327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cf-bottom jenkins with exotics with NO TESTS, please |
olehermanse
previously approved these changes
Sep 15, 2023
|
Alright, I triggered a build: (with exotics) [NO TESTS] Jenkins: https://ci.cfengine.com/job/pr-pipeline/9840/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9840/ |
|
@cf-bottom jenkins with exotics, please |
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/9844/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9844/ |
Only flakes and unrelated failures on exotics, AFAICT. |
larsewi
previously approved these changes
Sep 18, 2023
With fixed headers not including <config.h>.
With libntech's headers no longer pulling in platform.h, we need to add it together with some other headers to some places in the codebase.
vpodzime
force-pushed
the
master-libntech_header_cleanup_fixes
branch
from
07e8c23 to
bdfef78
Compare
|
Bumped libntech so need a re-ACK. |
larsewi
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With libntech's headers no longer pulling in platform.h, we need to add it together with some other headers to some places in the codebase.
Merge together:
#5327
NorthernTechHQ/libntech#192