Carefully handle symlinks at the last phase of VerifyFilePromise() #5444
Conversation
|
@cf-bottom please test this in Jenkins :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10429/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10429/ |
vpodzime
force-pushed
the
master-symlink_perms
branch
from
06b58cd to
20c21cb
Compare
Some acceptance tests need adjusting. Hopefully that's good news and the adapted tests will serve as tests for the new/right behavior. |
If the promiser is a symlink, `lstat()` and `stat()` give different results. We need to use `lstat()` to get info about the promiser (symlink) itself. Also, we need to call `VerifyFileLeaf()` on symlinks as well as on regular files. Ticket: ENT-11235 Changelog: Ownership of symlinks is now handled properly
Setting permissions on symlinks should not act on targets. Ticket: CFE-4148 Changelog: None
vpodzime
force-pushed
the
master-symlink_perms
branch
from
9dd093e to
b267435
Compare
|
@cf-bottom jenkins with exotics, please |
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/10433/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10433/ |
All green, just stuck in Jenkins and with an unrelated win-acceptance tests failure. |
If the promiser is a symlink,
lstat()andstat()give different results. We need to uselstat()to get info about the promiser (symlink) itself.Also, we need to call
VerifyFileLeaf()on symlinks as well as on regular files.Ticket: ENT-11235
Changelog: None