Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-10699: Fixed windows acceptance test workflow #5493

Merged
merged 2 commits into from
May 8, 2024
Merged

ENT-10699: Fixed windows acceptance test workflow #5493

merged 2 commits into from
May 8, 2024

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented May 3, 2024 •
edited
Loading

  • Improve and re-enable windows acceptance test workflow
  • Adjust expectations of windows acceptance tests

@cf-bottom
Copy link

Thank you for submitting a pull request! Maybe @larsewi can review this?

@craigcomstock craigcomstock marked this pull request as draft May 6, 2024 12:46
@craigcomstock craigcomstock marked this pull request as ready for review May 7, 2024 18:44
@craigcomstock
Copy link
Contributor Author

trying a rebuild of last night's master win-acceptance job in jenkins: Build Status

larsewi
larsewi approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@craigcomstock craigcomstock merged commit 5985033 into cfengine:master May 8, 2024
13 checks passed
@craigcomstock craigcomstock deleted the ENT-10699/master branch May 8, 2024 15:44
@craigcomstock
Copy link
Contributor Author

not sure I want to cherry-pick, but will try
#5502
#5501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsewi larsewi larsewi approved these changes

@vpodzime vpodzime Awaiting requested review from vpodzime

@aleksandrychev aleksandrychev Awaiting requested review from aleksandrychev

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigcomstock @cf-bottom @larsewi