This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Fix iOS stuck in infinite loop bug #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix probably solves issue #31 as well but I haven't tested it. |
|
@alexguzman - You sir, are a genius! Simple, elegant fix to multiple issues. This does in fact also fix #31, too. Thanks so much! |
cferdinandi
pushed a commit
that referenced
this pull request
Feb 10, 2014
Fix iOS stuck in infinite loop bug and Chrome browser zoom bug.
cferdinandi
pushed a commit
that referenced
this pull request
Feb 10, 2014
This was referenced Feb 10, 2014
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few iOS tests showed that the
scrollTofunction isn't exactly "pixel perfect" on iOS devices, and may produce an infinite loop (seems to be the cause of issue #34 as well).This fix forces the animation loop to stop if it is calling the last iteration of
animateScroll.