fixup! tests: Add basic e2e test

cfergeau · Oct 10, 2023 · 5c4bad2 · 5c4bad2
1 parent 6c23e62
commit 5c4bad2
Showing 1 changed file with 25 additions and 12 deletions.
diff --git a/test/vm_test.go b/test/vm_test.go
@@ -202,6 +202,9 @@ var pciidTests = map[string]pciidTest{
 			return config.VirtioFsNew("./", "vfkit-share-test")
 		},
 	},
+}
+
+var pciidMacOS13Tests = map[string]pciidTest{
 	"virtio-gpu": {
 		vendorID: 0x1af4, // Red Hat
 		deviceID: 0x1050,
@@ -225,6 +228,22 @@ var pciidTests = map[string]pciidTest{
 	},
 }
 
+func testPCIId(t *testing.T, test pciidTest, provider OsProvider) {
+	vm := NewTestVM(t, provider)
+	defer vm.Close(t)
+	require.NotNil(t, vm)
+
+	vm.AddSSH(t, "tcp")
+	dev, err := test.createDev(t)
+	require.NoError(t, err)
+	vm.AddDevice(t, dev)
+
+	vm.Start(t)
+	vm.WaitForSSH(t)
+	checkPCIDevice(t, vm, test.vendorID, test.deviceID)
+	vm.Stop(t)
+}
+
 func TestPCIIds(t *testing.T) {
 	puipuiProvider := NewPuipuiProvider()
 	log.Info("fetching os image")
@@ -234,19 +253,13 @@ func TestPCIIds(t *testing.T) {
 
 	for name, test := range pciidTests {
 		t.Run(name, func(t *testing.T) {
-			vm := NewTestVM(t, puipuiProvider)
-			defer vm.Close(t)
-			require.NotNil(t, vm)
-
-			vm.AddSSH(t, "tcp")
-			dev, err := test.createDev(t)
-			require.NoError(t, err)
-			vm.AddDevice(t, dev)
+			testPCIId(t, test, puipuiProvider)
+		})
+	}
 
-			vm.Start(t)
-			vm.WaitForSSH(t)
-			checkPCIDevice(t, vm, test.vendorID, test.deviceID)
-			vm.Stop(t)
+	for name, test := range pciidMacOS13Tests {
+		t.Run(name, func(t *testing.T) {
+			testPCIId(t, test, puipuiProvider)
 		})
 	}
 }