290 parse error #321
Merged
290 parse error #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xposed and output if a directory is supposed to be ignored.
|
I think it's about ready. Looks great. |
|
Ah - yeah. I didn't change those because you said initially I should look for the exception being fired for PARSE_ERROR only - and wasn't sure what it'd do for PLUGIN_ERROR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional refactoring to ignore the PARSE_ERRORs mentioned in #290. Current tests pass and my own real life test setup works too, now.
@ryaneberly Would you mind reviewing it again and if you think it's good to go, merge into dev? :)