Patch to support Tags on AWS::IAM::Role and AWS::Serverless::Function, add support for AWS::Serverless::Application #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaxwellau
changed the title
gergnz
approved these changes
Sep 1, 2019
gergnz
approved these changes
Sep 1, 2019
|
Thanks for the patch @cmaxwellau |
gergnz
pushed a commit
that referenced
this pull request
Oct 24, 2019
* offer option to 'lock' resource_specification.json version - Fix for #393 (#395) * offer option to 'lock' resource_specification.json version * rubocopped, fix failing tests * update readme file to reflect new -u option * use the gzip file instead as it's much faster on the wire - gergnz - fixes #394 * Patch release 0.16.10 * handle simple resource types (#397) * Add VPCEndpoint resource to address #398 (#399) * Patch release 0.16.11 * add instructions at the top of the readme on how to update the spec (#400) * add Cloudwatch Alarm, as it's missing Metrics, Fixes #401 * Patch release 0.16.12 * add InlineCode to serverless function * Patch release 0.16.13 * Added cfndsl patch for AWSEC2CapacityReservationTag Name Error (#409) * add the latest patches (#411) * fix all the latest rubocop issues (#410) * fix all the latest rubocop issues * undo cfndsl spec update test removal * add in a test for just the latest spec file * bump version in ruby * Minor release 0.17.0 * fix for rubocop 0.74 (#415) * Patch to support Tags on AWS::IAM::Role and AWS::Serverless::Function, add support for AWS::Serverless::Application (#413) * Patch to support Tags on AWS::IAM::Role and AWS::Serverless::Function * Rubocop fixes * Updated patch for Serverless_Function with correct tag type - Json * Add patch for AWS::Serverless::Application * Rubocap whitespace.. * Patch release 0.17.1 * update rubygems api key (#416) * Added Rules support for cross-parameter validation (#417) * First crack at support for Rules support detailed in #414 * #414 Updated plurals and disabled non-working ref check for rules * #414 Added support for Rule-specific intrinsic functions as per https://docs.aws.amazon.com/servicecatalog/latest/adminguide/intrinsic-function-reference-rules.html#supported-rule-functions * #414 Added spec tests and code cleanup for rules support * Revert version bump, cleanup code and fixed ref check for #414 * Removed debug * Fixed rubocop offense * Remove use of plurals * Patch release 0.17.2 * Fix for #418. This time with less pre 1.0.... (#420) * Patch to support Tags on AWS::IAM::Role and AWS::Serverless::Function * Rubocop fixes * Updated patch for Serverless_Function with correct tag type - Json * Add patch for AWS::Serverless::Application * Rubocap whitespace.. * Add patch for AWS::Serverless::Application * Rubocap whitespace.. * Fix for #418 - Warning on multiple top-level constants from external files * Rubocop fixes. I need to make this a pre-commit hook. * Better fix for #418 by checking if the key already exists via binding eval, instead of only checking for constant existence, and needing to write missing logic for non-constants which was causing the tests to fail. * Added spec test for #418 * Fix rubocop for spec test.. * Updated load_file tests to use fixtures instead of dynamically generated files * Patch release 0.17.3 * Suggest to not use system wide Ruby (#421) * improve test scenario for a basic merge in binding of multiple yaml files. Fixes #422 (#423) * Patch release 0.17.4 * Skip broken tests on 1.0.0-pre * Skip broken tests on 1.0.0-pre * Skip broken tests after merge with master * Silence warning output to re-establish tests * Rearrange requires to avoid prematurely loading embedded spec file Allow for patches to apply to a certain spec version range * rubygems 3.x does not like nil versions
gergnz
pushed a commit
that referenced
this pull request
Oct 27, 2019
* offer option to 'lock' resource_specification.json version - Fix for #393 (#395) * offer option to 'lock' resource_specification.json version * rubocopped, fix failing tests * update readme file to reflect new -u option * use the gzip file instead as it's much faster on the wire - gergnz - fixes #394 * Patch release 0.16.10 * handle simple resource types (#397) * Add VPCEndpoint resource to address #398 (#399) * Patch release 0.16.11 * add instructions at the top of the readme on how to update the spec (#400) * add Cloudwatch Alarm, as it's missing Metrics, Fixes #401 * Patch release 0.16.12 * add InlineCode to serverless function * Patch release 0.16.13 * Added cfndsl patch for AWSEC2CapacityReservationTag Name Error (#409) * add the latest patches (#411) * fix all the latest rubocop issues (#410) * fix all the latest rubocop issues * undo cfndsl spec update test removal * add in a test for just the latest spec file * bump version in ruby * Minor release 0.17.0 * fix for rubocop 0.74 (#415) * Patch to support Tags on AWS::IAM::Role and AWS::Serverless::Function, add support for AWS::Serverless::Application (#413) * Patch to support Tags on AWS::IAM::Role and AWS::Serverless::Function * Rubocop fixes * Updated patch for Serverless_Function with correct tag type - Json * Add patch for AWS::Serverless::Application * Rubocap whitespace.. * Patch release 0.17.1 * update rubygems api key (#416) * Added Rules support for cross-parameter validation (#417) * First crack at support for Rules support detailed in #414 * #414 Updated plurals and disabled non-working ref check for rules * #414 Added support for Rule-specific intrinsic functions as per https://docs.aws.amazon.com/servicecatalog/latest/adminguide/intrinsic-function-reference-rules.html#supported-rule-functions * #414 Added spec tests and code cleanup for rules support * Revert version bump, cleanup code and fixed ref check for #414 * Removed debug * Fixed rubocop offense * Remove use of plurals * Patch release 0.17.2 * Fix for #418. This time with less pre 1.0.... (#420) * Patch to support Tags on AWS::IAM::Role and AWS::Serverless::Function * Rubocop fixes * Updated patch for Serverless_Function with correct tag type - Json * Add patch for AWS::Serverless::Application * Rubocap whitespace.. * Add patch for AWS::Serverless::Application * Rubocap whitespace.. * Fix for #418 - Warning on multiple top-level constants from external files * Rubocop fixes. I need to make this a pre-commit hook. * Better fix for #418 by checking if the key already exists via binding eval, instead of only checking for constant existence, and needing to write missing logic for non-constants which was causing the tests to fail. * Added spec test for #418 * Fix rubocop for spec test.. * Updated load_file tests to use fixtures instead of dynamically generated files * Patch release 0.17.3 * Suggest to not use system wide Ruby (#421) * improve test scenario for a basic merge in binding of multiple yaml files. Fixes #422 (#423) * Patch release 0.17.4 * Skip broken tests on 1.0.0-pre * Skip broken tests on 1.0.0-pre * Skip broken tests after merge with master * Silence warning output to re-establish tests * Rearrange requires to avoid prematurely loading embedded spec file Allow for patches to apply to a certain spec version range * rubygems 3.x does not like nil versions * fix #403, #389 Use tsort for cycle detection Fixes and tests for clashing plurals * bump supported ruby version test travis on all supported ruby point releases * Fix nested conditions * Fix bug in error message when attempting to redefine Type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #412