This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
use tox to run tests against Python2.7 and 3.4 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure is by design ;) |
|
@rosskarchner Shouldn't we maybe add in the python 3 support before failing builds due to its absence? Also, let's talk about the plan for adding python 3 support this week. |
Tests can still be run against Python3 with: `tox -e py34`
|
I'm not too opinionated about that-- but it doesn't seem like an unreasonable way to set the bar we want to meet. I've fixed the branch so that testing against Python 3.4 is optional, and can be invoked with: tox -e py34 |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @catherinedevlin's suggestion in #32-- we should support Python 3. This PR helps us track that work, by using
toxto run our tests against Python 2.7 and 3.4, and configuring travis to use tox.Potential controversy: tox doesn't play well with nose-progressive, so I've disabled it and removed it from the requirements. Does anyone care?