Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump regulations-site to 2.2.1 #3774

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

niqjohnson
Copy link
Member

This commit bumps the optional regulations-site package to 2.2.1. That release adds support for a new Django setting, EREGS_REGULATION_UPDATES, that allows for placement of a message on the landing page of any regulation to let users know that we're working on incorporating the latest updates to that regulation. See cfpb/regulations-site#843

Additions

  • EREGS_REGULATION_UPDATES Django setting

Changes

  • Bump regulations-site to 2.2.1

Testing

  1. Run a local server with EREGS_API_BASE=https://www.consumerfinance.gov/eregs-api/ ./runserver.sh
  2. Pop on over to eRegs at http://localhost:8000/eregulations/
  3. View any of the regs that have an update in progress but don't have new amendments effective in the future: 1002, 1010, 1011, 1012, 1013, 1024, or 1026. The landing page for those regs should look like the "update only" screenshot below.
  4. View any of the regs that have both an update in progress and new amendments effective in the future: 1003 or 1005. The landing page for those regs should look like the "update and amendments" screenshot below.
  5. The link in either version of the notification should point to https://www.consumerfinance.gov/policy-compliance/rulemaking/final-rules/
  6. View any of the other regs that have neither an update in progress or amendments effective in the future: 1004 or 1030. The landing page for those regs should look like the "none" screenshot below.

Screenshots

Update only Update and amendments None
update-only both none

Notes

@chosak helped me prepare the regulations-site release and this PR (thanks!) and is going to review. I don't have push access to cfgov-refresh, so I couldn't add a reviewer and had to make this PR from my fork.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated
  • Reviewers requested with the Reviewer tool ➡️

This commit bumps the optional regulations-site package to 2.2.1 to add support for a new Django setting, EREGS_REGULATION_UPDATES, that allows for placement of a message on the landing page of certain regulations to let users know that an update in progress. See cfpb/regulations-site#843
Copy link
Member

@chosak chosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chosak chosak merged commit d3f5935 into cfpb:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants