Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yarn scripts, yarn styles, yarn copy tasks #8608

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

anselmbradford
Copy link
Member

There's a bug in the yarn scripts task where it needs a loader for SCSS. Instead of fixing that, I'm proposing ripping out the yarn scripts, yarn styles and yarn copy tasks and just having a single yarn build (and accompanying yarn watch) task. Build doesn't take that long, and that simplifies our maintenance of these scripts.

Removals

  • Remove yarn scripts, yarn styles, yarn copy tasks

How to test this PR

  1. yarn build and yarn watch should run without error.

Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suuuuuuuure. The bug is expected, since esbuild doesn't support scss. The only way the build works in the design system is by including the postcss sass plugin: https://github.com/cfpb/design-system/blob/main/esbuild/packages/scripts.js. But I agree this is fine in general. I do sometimes run these scripts individually, but watching is usually the better move.

@anselmbradford anselmbradford added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 2efe7ad Oct 16, 2024
11 checks passed
@anselmbradford anselmbradford deleted the ans_remove_build_flows branch October 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants