Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown/Select] CFPB Styling -- Parity #190

Open
6 tasks done
shindigira opened this issue Oct 3, 2023 · 2 comments
Open
6 tasks done

[Dropdown/Select] CFPB Styling -- Parity #190

shindigira opened this issue Oct 3, 2023 · 2 comments
Assignees
Labels

Comments

@shindigira
Copy link
Contributor

shindigira commented Oct 3, 2023

Changes

  • Dropdown Indicator Container -- caret should flip between up/down arrows
  • Dropdown Indicator Container -- change to width/height: 2.1875em
  • Dropdown Text -- should be #101820 color.
  • Dropdown -- Height should be 2.1875em.
  • Dropdown -- During errors, the right part (caret container) should have the normal border color.
  • The Dropdown component should pass the id to the Checkbox component (MultiSelect with Checkboxes)

Reference(s)

https://cfpb.github.io/design-system/components/selects

@shindigira shindigira self-assigned this Oct 3, 2023
@shindigira shindigira changed the title [Dropdown/Select] Flip the caret on expand/collapse [Dropdown/Select] Flip the caret on expand/collapse, width/height of singleValue should be the same Oct 5, 2023
@shindigira shindigira changed the title [Dropdown/Select] Flip the caret on expand/collapse, width/height of singleValue should be the same [Dropdown/Select] CFPB Styling -- Parity Oct 5, 2023
@meissadia
Copy link
Contributor

@shindigira Can you also take a look at the unit tests for Dropdown (yarn vitest Dropdown). I think they've been failing since #176 but I didn't catch it then. I'd also be glad to work on fixing those if you have other priorities, just let me know.

@natalia-fitzgerald
Copy link

natalia-fitzgerald commented Oct 6, 2023

Content review:

  • Shouldn't "Single Select Disabled" be a state that can be turned on/off (like we do for buttons) versus a Type? If it remains as a type change to sentence case "Single select (disabled)
  • Remove: "As a controlled version" type
  • Remove: "Single select default value"
  • Note: Tags still have to be added to the DS and then brought into the DSR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants