Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Renamed from Dropdown, Style Changes, Stories Updated #194

Closed
wants to merge 14 commits into from

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Oct 6, 2023

Closes #181
Closes #185
Closes #190

Select - Technical Changes

  • The Dropdown component should pass the id to the Checkbox component (MultiSelect with Checkboxes)

Select - Styling Changes

  • Dropdown Indicator Container -- Fix gray box that caret sits in
  • Dropdown Indicator Container -- caret should flip between up/down arrows
  • Dropdown Indicator Container -- change to width/height: 2.1875em
  • Dropdown Text -- should be #101820 color.
  • Select -- Height should be 2.1875em.
  • Select -- During an error state, the right part (caret container) should have the normal border color.
  • Checkbox should be vertically and horizontally centered in the box (DSR checkbox component is verified and reflects the correct implementation) Found to be a bug with the USWDS css file

Select - Stories Changes

Changes according to this list.

Select - Tests Updated

  • Run yarn vitest Select

Reference(s)

https://cfpb.github.io/design-system/components/selects

@shindigira shindigira added the enhancement New feature or request label Oct 6, 2023
@shindigira shindigira requested a review from meissadia as a code owner October 6, 2023 03:32
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit b6a9462
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/6528df5741205c000874a0cf
😎 Deploy Preview https://deploy-preview-194--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shindigira shindigira changed the title 181 185 190 select caret changes [Select] Renamed from Dropdown, Style Changes, Stories Updated Oct 6, 2023
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Still see Stories that were requested to be removed (w/ default value, as a controlled component, etc)
  • Select's unit tests are failing

@shindigira
Copy link
Contributor Author

shindigira commented Oct 10, 2023

  • Still see Stories that were requested to be removed (w/ default value, as a controlled component, etc)
  • Select's unit tests are failing

Thanks for the feedback. Will make the adjustment and fix the unit tests.

@shindigira
Copy link
Contributor Author

Closing this due to having Select/Multiselect rebuilt without react-select. See #197

@shindigira shindigira closed this Nov 20, 2023
@meissadia meissadia deleted the 181-185-190-select-caret-changes branch February 12, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants