-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Renamed from Dropdown
, Style Changes, Stories Updated
#194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shindigira
changed the title
181 185 190 select caret changes
[Select] Renamed from Oct 6, 2023
Dropdown
, Style Changes, Stories Updated
meissadia
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Still see Stories that were requested to be removed (w/ default value, as a controlled component, etc)
- Select's unit tests are failing
Thanks for the feedback. Will make the adjustment and fix the unit tests. |
Closing this due to having Select/Multiselect rebuilt without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181
Closes #185
Closes #190
Select - Technical Changes
Select - Styling Changes
Checkbox should be vertically and horizontally centered in the box (DSR checkbox component is verified and reflects the correct implementation)Found to be a bug with the USWDS css fileSelect - Stories Changes
Changes according to this list.
Select - Tests Updated
yarn vitest Select
Reference(s)
https://cfpb.github.io/design-system/components/selects