Add unit test for data-hook and instantiateAll #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the improvements! Browse a preview of your changes using the link below. Built with commit e749374 |
anselmbradford
changed the title
contolini
approved these changes
Jan 21, 2021
| } ); | ||
| } ); | ||
|
|
||
| describe( 'remove()', () => { |
There was a problem hiding this comment.
The remove() test is in here twice.
There was a problem hiding this comment.
🤔 not sure how that happened, but fixed!
| @@ -9,7 +9,7 @@ | |||
| - Atom | |||
| ========================================================================= */ | |||
|
|
|||
| import * as dataHook from './data-hook'; | |||
| import { add, contains, remove } from './data-hook'; | |||
There was a problem hiding this comment.
Why import the individual methods separately? For clarity?
There was a problem hiding this comment.
Yeah so if you search for the methods you will get the import statement in the search results. Also, if data-hook has more added to it, it won't be automatically pulled into this file where it's unneeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
data-hook.js.instantiateAlltest.Testing
gulp test:unitshould pass.