Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiselect: Add down arrow to multiselect #1162

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Multiselect: Add down arrow to multiselect #1162

merged 3 commits into from
Jan 22, 2021

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Jan 20, 2021 •
edited
Loading

Adds down arrow to multiselect to align the appearance with the regular drop-downs.
Closes [GHE]/CFGOV/platform/issues/2413

Changes

  • Adds down arrow to multiselect.
  • Increases touch width of multiselect labels to 100% of the available width.
  • Change search placeholder text to say "Select" instead of "Choose"

Testing

  1. Check Dropdowns and multiselects page in the PR preview and see that the multiselect has a drop-down arrow and you can click the items in the multiselect to the right of the label text.

Screenshots

Screen Shot 2021-01-20 at 4 17 33 PM

@anselmbradford anselmbradford added the lerna-changelog/enhancement lerna label. DO NOT MODIFY label Jan 20, 2021
@netlify
Copy link

netlify bot commented Jan 20, 2021

Thanks for the improvements! Browse a preview of your changes using the link below.

Built with commit 1ae135c

https://deploy-preview-1162--cfpb-design-system.netlify.app

@netlify
Copy link

netlify bot commented Jan 20, 2021 •
edited
Loading

Thanks for the improvements! Browse a preview of your changes using the link below.

Built with commit 295a3e2

https://deploy-preview-1162--cfpb-design-system.netlify.app

contolini
contolini approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! 👍 You should demo this after stand up. I'd vote to give the arrow a pointer cursor.

@anselmbradford anselmbradford merged commit 254b1ab into main Jan 22, 2021
@anselmbradford anselmbradford deleted the ans_multiselect_arrow branch January 22, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contolini contolini contolini approved these changes

@ielerol ielerol Awaiting requested review from ielerol

Assignees
No one assigned
Labels
lerna-changelog/enhancement lerna label. DO NOT MODIFY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @contolini