Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move __onload-open modifier to the parent component class #1632

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

anselmbradford
Copy link
Member

Doesn't make sense to put a modifier inside the component, it should be a modifier overall on o-expandable. This moves the modifier to the component from content.

Changes

  • Move __onload-open modifier to the parent component class

Testing

  1. PR preview expandable should work as before.

@anselmbradford anselmbradford added lerna-changelog/enhancement lerna label. DO NOT MODIFY lerna-changelog/breaking lerna label. DO NOT MODIFY and removed lerna-changelog/enhancement lerna label. DO NOT MODIFY labels Apr 18, 2023
@netlify
Copy link

netlify bot commented Apr 18, 2023

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 17db100
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/643f008c6f82430008704fb4
😎 Deploy Preview https://deploy-preview-1632--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 18, 2023

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit a544a06
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/643f00e296302c000883406f
😎 Deploy Preview https://deploy-preview-1632--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/breaking lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants