Remove large pull quote #1791
Merged
Remove large pull quote #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
niqjohnson
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Looks good. I was going to say we should also update our usage guidelines, but it turns out we don't have any usage guidelines on pull quotes, sooooo…
(We should probably write usage guidelines on pull quotes at some point, but that's definitely a separate issue.)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanying PR to cfpb/consumerfinance.gov#7999
I noticed the large pull quote is only used on https://www.consumerfinance.gov/data-research/consumer-complaints/
This pattern is very old and goes back to 2014 (added in cfpb/cf-typography#17)
We have the "is large" option in Wagtail to support the one use case in the CCDB landing page.
Consulting with @natalia-fitzgerald, it was decided it would be fine for this page to have the regular pull quote, which I have updated on the live site.
Removals
Testing
There wasn't an example of this in the DS, so there's nothing further to check beyond PR checks passing.