Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect: Remove display: -webkit-box property #1792

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

anselmbradford
Copy link
Member

#1117 set display: -webkit-box to fix an issue with a Chrome v87. Since that time the underlying chromium bug has been closed, and it appears that this property is now causing a more serious issue in Safari. See #1728

Fixes #1728

Changes

  • Remove display: -webkit-box property

Testing

  1. Check the PR preview in Safari and Chrome and see that the multiselect opens the same in both.

Screenshots

Before:

Screenshot 2023-10-25 at 8 15 29 PM

After:

Screenshot 2023-10-25 at 8 15 45 PM

@anselmbradford anselmbradford added the lerna-changelog/bug lerna label. DO NOT MODIFY label Oct 26, 2023
@netlify
Copy link

netlify bot commented Oct 26, 2023

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 21386f0
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/653a56303c273a0008d5ad16
😎 Deploy Preview https://deploy-preview-1792--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buh-bye

@anselmbradford anselmbradford merged commit c910480 into main Oct 27, 2023
8 checks passed
@anselmbradford anselmbradford deleted the ans_multiselect_safari_fix branch October 27, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/bug lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiselect: On desktop drop-down options lose background fill
2 participants