Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge o-expandable__padded into default and create new o-expandable__padded variant #1924

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Mar 6, 2024

Changes

  • Merge o-expandable__padded into default and create new o-expandable__padded variant

Testing

  1. There is a new padded expandable on https://deploy-preview-1924--cfpb-design-system.netlify.app/design-system/components/expandables. The other expandables should be unchanged.

Screenshots

Screenshot 2024-03-06 at 12 35 54 PM

@anselmbradford anselmbradford added the lerna-changelog/enhancement lerna label. DO NOT MODIFY label Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit b58f08e
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/65e8aadf8e1ffd00084715ca
😎 Deploy Preview https://deploy-preview-1924--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@csebianlander csebianlander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can modify the styling so the padding's also applied to the toggle icon (to get it roughly vertically centered) I think this will work perfectly.

@anselmbradford
Copy link
Member Author

anselmbradford commented Mar 6, 2024

If we can modify the styling so the padding's also applied to the toggle icon (to get it roughly vertically centered) I think this will work perfectly.

Updated in 9675849

Screenshot above has also been updated

@csebianlander csebianlander self-requested a review March 6, 2024 17:39
@anselmbradford
Copy link
Member Author

Slight update to remove the left-hand padding to align with https://www.consumerfinance.gov/learnmore/

Screenshot 2024-03-06 at 12 41 24 PM

@anselmbradford anselmbradford merged commit dcd3cd6 into main Mar 6, 2024
6 of 8 checks passed
@anselmbradford anselmbradford deleted the ans_merge_expanded branch March 6, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/enhancement lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants