Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfpb-notification: Add color contrast safe colors for links in an error notification #1944

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Apr 2, 2024

Fixes #1943

The standard link color on a red background in the alert notifications is not accessible.

Changes

  • cfpb-notification: Add color contrast safe colors for links in an error notification

Testing

  1. PR checks should pass. Visit the alert page in the PR preview and run Google Lighthouse and it should pass the accessibility check with 100%.

@anselmbradford anselmbradford added the lerna-changelog/bug lerna label. DO NOT MODIFY label Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 90d3f8c
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/660c1153b4d5b60009a46bf3
😎 Deploy Preview https://deploy-preview-1944--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@chosak chosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! For posterity we should note that this PR closes #1943.

@anselmbradford anselmbradford merged commit 56cfe82 into main Apr 2, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_error_colors branch April 2, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/bug lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Error alert link text fails accessibility contrast test
2 participants