Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine build scripts #2043

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Combine build scripts #2043

merged 2 commits into from
Sep 10, 2024

Conversation

anselmbradford
Copy link
Member

It is easy to accidentally build only the packages or the docs and miss out on changes in one or the other. This PR combines their build calls together.

Changes

  • Combine the packages and docs build scripts together into one yarn build call.

Testing

  1. yarn build should pass. PR checks should pass.

@anselmbradford anselmbradford added the lerna-changelog/internal lerna label. DO NOT MODIFY label Sep 10, 2024
Copy link

netlify bot commented Sep 10, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 412528a
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/66e0bccd87df9700073970bf
😎 Deploy Preview https://deploy-preview-2043--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably existed because the build used to be annoyingly slow

@anselmbradford anselmbradford merged commit 21b0f67 into main Sep 10, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_build branch September 10, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/internal lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants