Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add precomposed apple touch icon #130

Merged
merged 1 commit into from
Jan 6, 2020
Merged

add precomposed apple touch icon #130

merged 1 commit into from
Jan 6, 2020

Conversation

wpears
Copy link
Member

@wpears wpears commented Jan 3, 2020

Closes #126

@meissadia
Copy link
Contributor

This is not working for me. After building and serving locally, I try to use either the 'Add Bookmark' or 'Add to Homescreen' on iOS but the flag icon is not being used.

@meissadia
Copy link
Contributor

...And that was because I was testing against the wrong branch!

The 'Add to Home Screen' shows the flag icon as expected, however 'Add Bookmark' uses a React logo.

@meissadia
Copy link
Contributor

As discussed during standup the 'Add Bookmark' icon works correctly in Production.

🚀

@meissadia meissadia merged commit 449a024 into master Jan 6, 2020
@meissadia meissadia deleted the apple-touch branch January 6, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apple-touch-icon-precomposed.png 404
2 participants