Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the faq link to be an in-app link rather than an anchor #278

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

wpears
Copy link
Member

@wpears wpears commented Mar 3, 2020

Assists with #277, but the real fix there is in Kubernetes.

We should prefer in-app Links where they make sense, since they are lower overhead once the user has already loaded the main bundle.

@wpears wpears requested a review from meissadia March 3, 2020 23:56
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@meissadia meissadia merged commit eff71bf into master Mar 4, 2020
@meissadia meissadia deleted the db-faq-link branch March 4, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants