Refactor V619_2 edits to use dynamic dates #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredb96
commented
Sep 23, 2024
There was a problem hiding this comment.
Note that these files are no longer needed
jaredb96
commented
Sep 23, 2024
There was a problem hiding this comment.
Never unit tested 2023 so I added it here
jaredb96
commented
Sep 23, 2024
There was a problem hiding this comment.
Testing common version of edit with 2018
| @@ -4,11 +4,10 @@ import hmda.model.filing.lar.LarGenerators._ | |||
| import hmda.model.filing.lar.LoanApplicationRegister | |||
| import hmda.validation.rules.EditCheck | |||
| import hmda.validation.rules.lar.LarEditCheckSpec | |||
| import hmda.validation.rules.lar.validity._2018.V619_2 | |||
|
|
|||
| import hmda.validation.rules.lar.validity.common.V619_2 | |||
|
|
|||
| class V619_2Spec extends LarEditCheckSpec { | |||
There was a problem hiding this comment.
Can these tests be combined into a single test file in ...rules/lar/validity/common/V619_2Spec.scala to check that all the filing years work as expected for V619_2? That way we won't have as much repetitive code to test each year
There was a problem hiding this comment.
Sure thing good catch
rkovalik-raft
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor V619_2 edits to use passed in dates. Also replaced and deleted old V619_2 edits and updated unit tests.