This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Allow multiple dashes in section names #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the expected URL pattern for reg section labels so that instead of supporting only e.g. "1005-a" it also supports sections like "1005-a-interp". This fixes some 500 errors that were being generated due to a "1005-Appendices-Interp" section in Reg E. You can confirm that this works to view diffs in the most recent Reg E content in regulations-stub by hitting this URL locally: http://localhost:8000/eregulations/diff/1005-2/2016-24506/2016-24503_20181001?from_version=2016-24506#1005-2-a The section label is passed around the code in various places so it's possible that adding this flexibility might break something else downstream. All current unit tests pass with this change, however, so I'd rather enable this (which seems like a reasonable assumption, unless there's some section naming guidelines somewhere that are being violated) and handle errors as they come up.
ascott1
approved these changes
Nov 6, 2017
chosak
added a commit
that referenced
this pull request
Nov 9, 2017
This change fixes a bug introduced by #836 that incorrectly passed section views to subterp views. It restores the previous section pattern and introduces a new section_or_subterp pattern that's used only for diff URLs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the expected URL pattern for reg section labels so that instead of supporting only e.g. "1005-a" it also supports sections like "1005-a-interp". This fixes some 500 errors that were being generated due to a "1005-Appendices-Interp" section in Reg E.
You can confirm that this works to view diffs in the most recent Reg E content in regulations-stub by hitting this URL locally:
http://localhost:8000/eregulations/diff/1005-2/2016-24506/2016-24503_20181001?from_version=2016-24506#1005-2-a
The section label is passed around the code in various places so it's possible that adding this flexibility might break something else downstream. All current unit tests pass with this change (
python manage.py test), however, so I'd rather enable this (which seems like a reasonable assumption, unless there's some section naming guidelines somewhere that are being violated) and handle errors as they come up.