Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update when links open in new tab #1071

Open
2 of 3 tasks
Tracked by #800
meissadia opened this issue Dec 5, 2024 · 0 comments · May be fixed by #1100
Open
2 of 3 tasks
Tracked by #800

Update when links open in new tab #1071

meissadia opened this issue Dec 5, 2024 · 0 comments · May be fixed by #1100
Assignees
@meissadia

Comments

@meissadia
Copy link
Contributor

meissadia commented Dec 5, 2024 •
edited
Loading

cfpb/sbl-ux#18

Tasks:

  • Integrate logic into the SBL Link component that determines when to open a link in a new tab based on the Acceptance criteria set in [Story] Certain links to open in a new tab sbl-project#295
  • Go through code and remove any overrides that force links to open in new tabs (Link > isExternalLink)
  • Add E2E tests for each link to verify it opens as expected (Same tab vs New tab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meissadia meissadia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Programmatically determine when links should open in new tabs cfpb/sbl-frontend
1 participant
@meissadia