Open external links in new tab #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meissadia
requested review from
billhimmelsbach,
shindigira and
ojbravo
as code owners
billhimmelsbach
approved these changes
Jun 30, 2024
There was a problem hiding this comment.
Heyo! Looks good, and I've added a ticket to discuss adding this functionality to ListLinks too post-mvp 👍
49 tasks
shindigira
added a commit
that referenced
this pull request
Sep 16, 2024
…me): additional resources - clicking opens new tabs (#796) closes #795 Followup to #779, #784 ## Changes - feat: `ListLinks` now open new tabs by default - enhancement: Footer & Filing Home - additional resources - clicking opens new tabs ## How to test this PR - Click Footer and Additional Resource Links ## Screenshots <img width="820" alt="Screenshot 2024-07-09 at 12 45 15 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/87292507-604f-48bf-8b26-af2d9f835051"> <img width="303" alt="Screenshot 2024-07-09 at 12 55 06 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/c96968aa-c9aa-47b6-8250-cbe54219761c"> ## References #784 #779
|
@billhimmelsbach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #779
Changes
target="_blank"sHow to test this PR
Review your FI profilesection; Should open in same tabUploadpage and click on the "filing instructions guide..." link, should open in new tab