Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Wagtail 3.0 #69

Merged
merged 6 commits into from
Jul 8, 2022
Merged

Update for Wagtail 3.0 #69

merged 6 commits into from
Jul 8, 2022

Conversation

willbarton
Copy link
Member

This PR updates Wagtail-Flags for Wagtail 3.0 and Django 4.0. This PR also drops support for Wagtail < 2.15 (the current LTS release) and Django < 3.2 (the current LTS release).

Wagtail 3.0 support requires some minor adjustments to our Wagtail imports and icon usage. SVG icons were introduced before 2.15. Django 4.0 support requires some minor adjustments to our application config and signals.

I've made the appropriate changes to our tox test matrix, and while in here, I've also converted the setup.py options to setup.cfg and moved the flake8 and isort configuration there.

Declare support for Django 3.2 and 4.0, and Wagtail 2.15 to 3.0.
This change removes the deprecated `providing_args` argument from Signal(), and removes default_app_config, and adds an explicit USE_TZ=True.
We don’t do anything other than set options in our existing setup.py, which is the purpose of setup.cfg. This change moves those to setup.cfg and removes those from setup.py.

It also moves our flake8 and isort config to setup.cfg.
@willbarton willbarton force-pushed the wagtail30 branch 4 times, most recently from 1cc57b7 to 485a1fc Compare July 7, 2022 13:46
Copy link
Contributor

@jslay-excella jslay-excella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

My quick tests locally work.

@willbarton willbarton merged commit 0e274ee into main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants