Add security consideration for HSM #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looks perfect to me, I think the only thing left is to evaluate if adding test vectors for X25519 and X448 makes sense. |
|
It makes sense to me, and I think @chris-wood was also in favor. X25519 is widespread and has good support, X448 is not as much. Including these vectors would be better done in another PR. |
chris-wood
approved these changes
Oct 4, 2021
What issue should we use to track this? |
Co-authored-by: Christopher Wood <caw@heapingbits.net>
bytemare
commented
Oct 5, 2021
Co-authored-by: Daniel Bourdrez <3641580+bytemare@users.noreply.github.com>
chris-wood
approved these changes
Oct 5, 2021
|
@chris-wood how about #238 for tracking? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #257