Merge pull request btcsuite#1228 from Roasbeef/fix-peer-goroutine-leak

peer: ensure the version negotiation goroutine will always exit
cfromknecht · Jul 22, 2018 · 9a2f952 · 9a2f952
2 parents f673a4b + 088eec6
commit 9a2f952
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/peer/peer.go b/peer/peer.go
@@ -2053,7 +2053,7 @@ func (p *Peer) Disconnect() {
 func (p *Peer) start() error {
 	log.Tracef("Starting peer %s", p)
 
-	negotiateErr := make(chan error)
+	negotiateErr := make(chan error, 1)
 	go func() {
 		if p.inbound {
 			negotiateErr <- p.negotiateInboundProtocol()