Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ProgressCallback doc comment #1587

Closed
wants to merge 1 commit into from
Closed

Conversation

tp
Copy link
Contributor

@tp tp commented Nov 1, 2022

This merge request fixes / refers to the following issues:

Small typo in the doc comment for ProgressCallback.

@AlexV525
Copy link
Member

AlexV525 commented Nov 8, 2022

Hi @tp, can you explain the reason why it should be sending? IMO the callback will be only called when the corresponding data started to receive.

@tp
Copy link
Contributor Author

tp commented Nov 9, 2022

Hi @tp, can you explain the reason why it should be sending? IMO the callback will be only called when the corresponding data started to receive.

Hey @AlexV525, the same callback definition is used for the sending (e.g. file upload) and response receiving progress:

CleanShot 2022-11-09 at 10 12 30@2x

source: https://pub.dev/documentation/dio/latest/dio/Dio/post.html

Thus the documentation lists the 2 distinct cases, the the value of total has a different meaning in each (outgoing vs. incoming bits).

@AlexV525
Copy link
Member

AlexV525 commented Dec 18, 2022

Hi @tp. We've made our repo public and published a new version of dio, named diox.
The new package contains the PR of the fix.
Please refer to https://pub.dev/packages/diox/versions/5.0.0-dev.1 to use the fork.
You can also see why we're working for a hardfork at cfug/diox#29 and #1607.

@AlexV525 AlexV525 closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants