[native_dio_adapter] ✨ Adds createCronetEngine and createCupertinoConfiguration
#2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexV525
added
p: native_dio_adapter
ueman
approved these changes
Nov 25, 2023
ueman
reviewed
Nov 25, 2023
| 'Use createCupertinoConfiguration instead. ' | ||
| 'This will cause platform exception on the Android platform. ' | ||
| 'This will be removed in v2.0.0', | ||
| ) | ||
| URLSessionConfiguration? cupertinoConfiguration, | ||
| }) { | ||
| if (Platform.isAndroid) { |
There was a problem hiding this comment.
Unrelated to this PR, but I guess we could make use of https://pub.dev/packages/platform here later to enable better testing in the future
AlexV525
deleted the
feat/native-dio-adapter-create-configuration-by-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to deprecate
cronetEngineandcupertinoConfigurationfor theNativeAdapter, to avoid platform exceptions.Fixes #2039.
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding package