Add ability to change [FileMode] of the download by introducing [Dio… #2281
Conversation
|
Can you please explain how this change enables resuming downloads? |
When downloading a file a stream is opened and a Random Access File are opened in the client side to store bytes changing the file access mode to [FileMode.append] or [FileMode.writeOnlyAppend] with change the behavior to write to the end of the file So if you had already started downloading a file and for some reason the download stopped let's say a network problem and you set [deleteOnError = false], the file had already downloaded 50% and it's not deleted it exists but is not complete You check if the file exists and get it's size then you request to download the file again by requesting a partial content setting the range header to file size, that means skip downloading the 50% you already downloaded then you append the remaining 50% to the end of the file and here it's you resumed your download with minimum ease. |
Ok, I will add tests. |
|
I wonder whether it makes sense to automatically add range header in the case of a resuming download, that way it would work out of the box, without the user needing to implement anything. The server needs to support them though. (This is not something which necessarily needs to be added to this PR though, I guess) |
Yes, it's a good idea. I think it's rare to find a server that doesn't support range requests. |
I added test case for the file mode append, now can you review the code again |
dio/lib/src/dio_file_mode.dart
Outdated
| /// - [DioFileMode.append]: Mode for opening a file for reading and writing | ||
| /// to the end of it. The file is created if it does not already exist. | ||
| /// {@endtemplate} | ||
| enum DioFileMode { |
There was a problem hiding this comment.
The name is a bit overwhelming. The type is only used for the download process.
Also the enhanced enum is not working on our minimum SDK support.
There was a problem hiding this comment.
I will convert it to extension
There was a problem hiding this comment.
any suggestion for naming
change [DioFileMode] to [FileAccessMode] change [Dio.download(fileMode:)] to [dio.download(fileAccessMode:)]
|
@ueman Could you follow above reviews and stamp this if applicable? |
Co-authored-by: Alex Li <github@alexv525.com> Signed-off-by: shehab mohame <shehabman@gmail.com>
Remove [FileAccessModeExtension]
|
The CI is complaining about the v1 of |
Co-authored-by: Alex Li <github@alexv525.com> Signed-off-by: shehab mohame <shehabman@gmail.com>
Co-authored-by: Alex Li <github@alexv525.com> Signed-off-by: shehab mohame <shehabman@gmail.com>
Rename "mode" in `DioMixin.downloadUri` to "fileAccessMode" Change var to int in "appeand bytes to previos download" test
…FileMode]
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)
Add the ability to change the [FileMode] of the download without altering the default value, which is [FileMode.write], to make resuming downloads easier to implement by introducing [DioFileMode] and mapping it to FileMode in [DioForNative]
without breaking web_adapter