✨ Add requestUrl & responseUrl to LogInterceptor for more precise controls
#2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhnroyal
approved these changes
Oct 24, 2025
Member
Author
|
@copilot Add tests and update docs/comments accordingly |
Contributor
7 tasks
…se controls (#2463) Resolves #2450 Adds `requestUrl` and `responseUrl` boolean parameters to `LogInterceptor` for granular control over URL logging, independent of other request/response details. ### Changes - **LogInterceptor API**: Added `requestUrl` (default: true) and `responseUrl` (default: true) parameters - **Tests**: Added 8 test cases covering flag combinations, independence, and default values - **Documentation**: Fixed incorrect doc comments (`requestUrl` was labeled "request header") - **CHANGELOG**: Added entry under Unreleased ### Example ```dart dio.interceptors.add( LogInterceptor( requestUrl: true, // Log request URL requestHeader: false, // Skip request headers responseUrl: false, // Skip response URL responseBody: true, // Log response body ), ); ``` ### New Pull Request Checklist - [x] I have read the [Documentation](https://pub.dev/documentation/dio/latest/) - [x] I have searched for a similar pull request in the [project](https://github.com/cfug/dio/pulls) and found none - [ ] I have updated this branch with the latest `main` branch to avoid conflicts (via merge from master or rebase) - [x] I have added the required tests to prove the fix/feature I'm adding - [x] I have updated the documentation (if necessary) - [ ] I have run the tests without failures - [x] I have updated the `CHANGELOG.md` in the corresponding package ### Additional context and info (if any) Tests will be validated by CI. Code review and security checks passed locally. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2450
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)