Skip to content

test: fix download tests for /bytes endpoint size limit #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexV525 merged 1 commit into from
Nov 16, 2025
Merged

test: fix download tests for /bytes endpoint size limit #2460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 39 additions & 24 deletions dio_test/lib/src/test/download_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ void downloadTests(
test('bytes', () async {
final path = p.join(tmp.path, 'bytes.txt');

final size = 50000;
final size = 50;
int progressEventCount = 0;
int count = 0;
int total = 0;
Expand All @@ -56,12 +56,12 @@ void downloadTests(

final res = await dio.get<ResponseBody>(
'/drip',
queryParameters: {'duration': '5', 'delay': '0'},
queryParameters: {'delay': '0', 'duration': '2'},
options: Options(responseType: ResponseType.stream),
cancelToken: cancelToken,
);

Future.delayed(const Duration(seconds: 2), () {
Future.delayed(const Duration(seconds: 1), () {
cancelToken.cancel();
});

Expand Down Expand Up @@ -94,7 +94,7 @@ void downloadTests(
dio.download(
'/drip',
path,
queryParameters: {'duration': '5', 'delay': '0'},
queryParameters: {'delay': '0', 'duration': '2'},
cancelToken: cancelToken,
),
throwsDioException(
Expand All @@ -110,11 +110,12 @@ void downloadTests(
test('cancels streamed response mid request', () async {
final cancelToken = CancelToken();
final response = await dio.get(
'/bytes/${1024 * 1024 * 100}',
'/drip',
queryParameters: {'delay': '0', 'duration': '2', 'numbytes': '20'},
options: Options(responseType: ResponseType.stream),
cancelToken: cancelToken,
onReceiveProgress: (c, t) {
if (c > 5000) {
if (c > 10) {
cancelToken.cancel();
}
},
Expand All @@ -135,11 +136,12 @@ void downloadTests(

await expectLater(
dio.download(
'/bytes/${1024 * 1024 * 10}',
'/drip',
path,
queryParameters: {'delay': '0', 'duration': '2', 'numbytes': '20'},
cancelToken: cancelToken,
onReceiveProgress: (c, t) {
if (c > 5000) {
if (c > 10) {
cancelToken.cancel();
}
},
Expand All @@ -158,7 +160,7 @@ void downloadTests(
final savePath = p.join(tmp.path, 'download0.md');

final options = Options(responseType: ResponseType.plain);
await dio.download('/bytes/1000', savePath, options: options);
await dio.download('/bytes/50', savePath, options: options);
expect(options.responseType, ResponseType.plain);
});

Expand Down Expand Up @@ -248,8 +250,13 @@ void downloadTests(
test('receiveTimeout triggers if gaps are too big', () {
expectLater(
dio.download(
'/drip?delay=0&duration=6&numbytes=3',
'/drip',
p.join(tmp.path, 'download_timeout.md'),
queryParameters: {
'delay': '0',
'duration': '4',
'numbytes': '2',
},
options: Options(receiveTimeout: const Duration(seconds: 1)),
),
throwsDioException(
Expand All @@ -264,8 +271,13 @@ void downloadTests(
() {
expectLater(
dio.download(
'/drip?delay=0&duration=6&numbytes=12',
'/drip',
p.join(tmp.path, 'download_timeout.md'),
queryParameters: {
'delay': '0',
'duration': '4',
'numbytes': '8',
},
options: Options(receiveTimeout: const Duration(seconds: 1)),
),
completes,
Expand All @@ -280,9 +292,10 @@ void downloadTests(

await expectLater(
dio.download(
'/drip?delay=0&duration=5',
'/drip',
savePath,
deleteOnError: true,
queryParameters: {'delay': '0', 'duration': '2'},
onReceiveProgress: (count, total) => throw AssertionError(),
),
throwsDioException(
Expand All @@ -309,7 +322,7 @@ void downloadTests(

await expectLater(
dio.download(
'/bytes/5000',
'/bytes/50',
savePath,
deleteOnError: true,
cancelToken: cancelToken,
Expand All @@ -335,12 +348,13 @@ void downloadTests(

await expectLater(
dio.download(
'/bytes/10000',
'/drip',
savePath,
queryParameters: {'delay': '0', 'duration': '2', 'numbytes': '20'},
cancelToken: cancelToken,
deleteOnError: true,
onReceiveProgress: (c, t) {
if (c > 5000) {
if (c > 10) {
cancelToken.cancel();
}
},
Expand All @@ -360,21 +374,21 @@ void downloadTests(

await expectLater(
dio.download(
'/bytes/5000',
'/bytes/50',
testPath,
),
completes,
);
await expectLater(
dio.download(
'/bytes/5000',
'/bytes/50',
(headers) => testPath,
),
completes,
);
await expectLater(
dio.download(
'/bytes/5000',
'/bytes/50',
(headers) async => testPath,
),
completes,
Expand All @@ -384,15 +398,15 @@ void downloadTests(
test('append bytes to previous download', () async {
final cancelToken = CancelToken();
final path = p.join(tmp.path, 'download_3.txt');
final requestedBytes = 1024 * 1024 * 10;
int recievedBytes1 = 0;
await expectLater(
dio.download(
'/bytes/$requestedBytes',
'/drip',
path,
queryParameters: {'delay': '0', 'duration': '2', 'numbytes': '20'},
cancelToken: cancelToken,
onReceiveProgress: (c, t) {
if (c > 5000) {
if (c > 10) {
recievedBytes1 = c;
cancelToken.cancel();
}
Expand All @@ -409,12 +423,13 @@ void downloadTests(
int recievedBytes2 = 0;
expectLater(
dio.download(
'/bytes/$requestedBytes',
'/drip',
path,
cancelToken: cancelToken,
queryParameters: {'delay': '0', 'duration': '2', 'numbytes': '20'},
cancelToken: cancelToken2,
onReceiveProgress: (c, t) {
recievedBytes2 = c;
if (c > 5000) {
if (c > 10) {
cancelToken2.cancel();
}
},
Expand Down