Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

add service to_background #66

Merged
merged 8 commits into from
Dec 27, 2021
Merged

add service to_background #66

merged 8 commits into from
Dec 27, 2021

Conversation

chpego
Copy link
Contributor

@chpego chpego commented Dec 23, 2021

maybe fix this issue #64

Copy link
Owner

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change. I'll try to get the lib bumped shortly so you can update the manifest too.

custom_components/fullykiosk/sensor.py Outdated Show resolved Hide resolved
@chpego
Copy link
Contributor Author

chpego commented Dec 23, 2021

Ok, i remove the last line, but i don't know why checks aren't successful :/

@cgarwood
Copy link
Owner

It's failing the isort check:

@@ -29,8 +29,8 @@ from .const import (
     SERVICE_RESTART_APP,
     SERVICE_SET_CONFIG,
     SERVICE_START_APPLICATION,
-    SERVICE_TO_FOREGROUND,
     SERVICE_TO_BACKGROUND,
+    SERVICE_TO_FOREGROUND,
 )

basically it just wants SERVICE_TO_BACKGROUND, moved above SERVICE_TO_FOREGROUND, in the import.

@cgarwood
Copy link
Owner

python-fullykiosk 0.0.11 is publishing now with the updated to background function. That will need updated in the manifest and then we're ready to merge 🙂

bump to python-fullykiosk 0.0.11 version
Copy link
Owner

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

HACS Validation check failure is a HACS issue, not an issue with this PR.

@cgarwood cgarwood merged commit 2d81a68 into cgarwood:master Dec 27, 2021
@chpego chpego deleted the patch-1 branch December 27, 2021 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants