Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't format years toLocaleString #740

Merged
merged 3 commits into from
Nov 28, 2016
Merged

Don't format years toLocaleString #740

merged 3 commits into from
Nov 28, 2016

Conversation

leehart
Copy link
Collaborator

@leehart leehart commented Nov 28, 2016

Addresses #728

@benjeffery
Copy link
Member

I realise this is a bit of a fudge request, but 2,004 is confusing...

@benjeffery benjeffery merged commit a54565b into master Nov 28, 2016
@leehart
Copy link
Collaborator Author

leehart commented Nov 28, 2016

I expect a non-fudge would probably allow/require columns to be specified as a year type or maybe some flexible superset.

It looks like MySQL has a Year type, http://dev.mysql.com/doc/refman/5.7/en/year.html

@leehart leehart deleted the noFormatYear branch November 28, 2016 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benjeffery benjeffery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leehart @benjeffery