New: Added support for new Vanilla button color mixins (fixes #32) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generic .btn-text and .btn-icon styles in Vanilla button.less - same issue applies to Hint master. Plugin styles are being overwritten by Vanilla.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
New
filledto mimic current Vanilla andoutlineas optional style. The implementation allows for additional styles to be created for custom themes.btn-textand.btn-iconstyles in Vanilla button.less). Same issue applies to Hint master, this wasn't introduced during this PR.Testing legacy support
Testing new Vanilla buttons
@item-ui-color-stylevariable in less/_defaults/_btn-style.less. Test bothfilledandoutlinestyles.