Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Set up inheritance config (fixes #22) #23

Merged
merged 2 commits into from
Jan 15, 2025
Merged

New: Set up inheritance config (fixes #22) #23

merged 2 commits into from
Jan 15, 2025

Conversation

guywillis
Copy link
Contributor

Fixes: #22

New

  • Add new _inheritCourseConfig boolean config option.
  • New config option allows for course level inheritance of footer config or to override on a per page basis

@guywillis guywillis requested a review from swashbuck January 13, 2025 15:25
@guywillis guywillis self-assigned this Jan 13, 2025
@swashbuck
Copy link
Contributor

@guywillis Looks good. Will you add this to the example.json and README.md, too?

@guywillis
Copy link
Contributor Author

@guywillis Looks good. Will you add this to the example.json and README.md, too?

Of course, yes. Apologies, I should have done this before requesting a review. Those entries should be there now.

swashbuck
swashbuck approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swashbuck swashbuck merged commit 1b47c64 into master Jan 15, 2025
@swashbuck swashbuck deleted the issue/22 branch January 15, 2025 21:35
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck swashbuck approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@guywillis guywillis

Labels
bug enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer graphic not shown when _footerContent is empty
3 participants
@guywillis @swashbuck @oliverfoster