Unexpected nodes in keywords #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds test cases to avoid nested unexpected nodes.
|
@cgrand Could you merge this? REPL-y and thus Leiningen are affected by an issue which in my case didn't let me use XML namespaces with the latest stable |
|
@cgrand Could you cut a new release so that this fix can be used in leiningen and reply? |
|
hi @cgrand, is there any way i/we can help in rolling out a new release? @trptcolin is hoping to roll this fix into a minor release for repl-y (see reply/#174 for more detail). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the two cases described in #22, where keywords have either a
:or a#character in the middle, and adds more testing to avoid unexpected nodes.