Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album Art is never displayed #142

Open
grantbacon opened this issue Dec 4, 2018 · 1 comment
Open

Album Art is never displayed #142

grantbacon opened this issue Dec 4, 2018 · 1 comment

Comments

@grantbacon
Copy link
Contributor

I notice that there's never album art displayed, but a few sites you can easily retrieve album art from (spotify, soundcloud). I'm not sure of others.

I see some existing code that looks like it was trying to accomplish this; I may try to submit a PR to include this if I can figure it out.

Any objections or suggestions are appreciated. :)

@cgravolet
Copy link
Owner

If I recall (I may be wrong), this is the commit that broke the album art. It fixed another problem, and there was some refactoring I planned to do to how it retrieves album art, but I never got around to it. Feel free to take a look at it, I don't have much time these days to devote to scroblr. Last.fm has an API to retrieve album art from, which is what scroblr uses, so would prefer to continue using that, there are just some bugs that need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants