fix: pkg_manifest_minimal example
#1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrindel
requested review from
brentleyjones,
jpsim and
luispadron
as code owners
luispadron
approved these changes
Jan 28, 2025
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 94db58f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out #1429, the
pkg_manifest_minimalexample was callingComplexClass.greet()and printing the result, but the function did not return anything. Instead, it was printing ingreet()function. That was not the original intent. I updatedComplexClass.greet()to return the greeting so that the executable can print it. I also added a check indo_testto confirm that it was being output properly. All of this was a miss on my part.Thanks to @0xLucasMarcal for pointing this.