Skip to content

Commit

Permalink
ostree-ext: Add bootc feature
Browse files Browse the repository at this point in the history
This is aiming to fix coreos/rpm-ostree#5251
Basically we can't re-invoke the calling process if we aren't
actually bootc.

(There are solutions that make this work, but what we'll hopefully
 do shortly is propagate the logic to older streams to have
 bootc take over the handling anyways)

Signed-off-by: Colin Walters <walters@verbum.org>
  • Loading branch information
cgwalters committed Jan 24, 2025
1 parent 4c5e4f2 commit 57111be
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ anyhow = { workspace = true }
bootc-utils = { path = "../utils" }
bootc-blockdev = { path = "../blockdev" }
camino = { workspace = true, features = ["serde1"] }
ostree-ext = { path = "../ostree-ext" }
ostree-ext = { path = "../ostree-ext", features = ["bootc"] }
chrono = { workspace = true, features = ["serde"] }
clap = { workspace = true, features = ["derive","cargo"] }
clap_mangen = { workspace = true, optional = true }
Expand Down
2 changes: 2 additions & 0 deletions ostree-ext/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ features = ["dox"]
docgen = ["clap_mangen"]
dox = ["ostree/dox"]
internal-testing-api = ["xshell", "indoc", "similar-asserts"]
# Enable calling back into bootc
bootc = []

[lints]
workspace = true
3 changes: 3 additions & 0 deletions ostree-ext/src/container/deploy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ pub async fn deploy(
// crates. We need an option to skip though so when the *main*
// bootc install code calls this API, we don't do this as it
// will have already been handled.
// Note also we do this under a feature gate to ensure rpm-ostree
// doesn't try to invoke this, as that won't work right now.
#[cfg(feature = "bootc")]
if !options.skip_completion {
// Note that the sysroot is provided as `.` but we use cwd_dir to
// make the process current working directory the sysroot.
Expand Down

0 comments on commit 57111be

Please sign in to comment.