Add authentication for Redis #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +65,11 @@ def get_status(self): | |||
| host = config.KEY_VALUE_STORE["host"] | |||
| port = config.KEY_VALUE_STORE["port"] | |||
| db = config.KV_JOB_DB_INDEX | |||
| url = "redis://%s:%s/%s" % (host, port, db) | |||
| password = (config.KEY_VALUE_STORE["password"],) | |||
There was a problem hiding this comment.
I think you have problem there. You assign a tuple to password
nledez
force-pushed
the
redis-with-password
branch
from
12951e0 to
1262291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to secure Redis with a password
Solution
Add password authentication to Redis