Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various improvements #867

Merged
merged 5 commits into from
Oct 8, 2024
Merged

various improvements #867

merged 5 commits into from
Oct 8, 2024

Conversation

EvanBldy
Copy link
Member

@EvanBldy EvanBldy commented Oct 8, 2024

Problem

  • Some requirements are outdated.
  • Due to a change in names_service.get_full_entity_name (it returns a 3-tuple now), there's a ValueError exception.
  • Black.
  • For Task.difficulty there's no constraint directly added on Postgres.

Solution

  • Upgrade outdated requirements.
  • Fix ValueError exceptions for names_service.get_full_entity_name.
  • Add constraint in migration file + set the default value to 3 and disable null values.

@EvanBldy EvanBldy merged commit 96a4dae into cgwire:master Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant