Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various improvements #914

Merged
merged 5 commits into from
Jan 27, 2025
Merged

various improvements #914

merged 5 commits into from
Jan 27, 2025

Conversation

EvanBldy
Copy link
Member

Problem

  • Some requirements are outdated.
  • For DepartmentMetadataDescriptorLink / TaskTypeAssetTypeLink tables no primary keys.
  • Routes using zou/app/services/tasks_service._convert_rows_to_detailed_tasks are slow due to querying each task.
  • When the search index is not configured, it spam many errors in the logs.

Solution

  • Upgrade outdated requirements.
  • For DepartmentMetadataDescriptorLink / TaskTypeAssetTypeLink tables add index, primary keys, unicity constraint.
  • Optimize zou/app/services/tasks_service._convert_rows_to_detailed_tasks to stop querying each task.
  • Stop spamming many errors when the search index is not configured.

@frankrousseau frankrousseau merged commit 9de1585 into cgwire:main Jan 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants