fix(embassy): avoid setting tick feature in hal #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo.toml
Outdated
| embassy-time-driver = { version = "0.1.0", features = [ | ||
| "tick-hz-1_000_000", | ||
| ], optional = true } | ||
| embassy-time-driver = { version = "0.1.0", optional = true } | ||
| embassy-time = { version = "0.3.0", features = [ | ||
| "tick-hz-1_000_000", |
There was a problem hiding this comment.
I think that the tick feature should also be removed for emabssy-time.
And we might need to add the feature in the examples, as done in embassy.
There was a problem hiding this comment.
Thanks for the comment. I'm back from holidays.
I'll get this merged soon.
andelf
force-pushed
the
fix/systick-stuck
branch
2 times, most recently
from
4c8c8c7 to
5c64390
Compare
andelf
force-pushed
the
fix/systick-stuck
branch
from
5c64390 to
c816eb7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See-also: #6
Needs more verification.
Update:
tick-hz_*features from-hal