Updating NET Core branch to 1.1 and Async #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the current example output has 2 typos (misspelling Pennsylvania, wrong apostrophe location in President's) and the wrong zip, so just ran the code and pasted the output into the editor for README.md
- space formatting in GoogleAddress - space formatting in GoogleGeocoder - added public getter for PlaceId
Adding Mixed SideOfStreet to MapQuest
…sand) Don't use Wilshire and Bundy as test input string, because "Wilshire Bundy Plaza" matches to this request and return place, but not intersection.
since it doesn't require an API key
* master: Don't include test project in ilmerged output Register google as default geocoder for example app Update .gitignore for VS 2015 Updating readme mapquest issues Upgrade Geocoding.Net in Example.sln. Can't reproduce chadly#45 and chadly#48. They are already fixed by commit ecc8cf6 Split tests for special characters and Street intersections (by ampersand) Test MapQuest Commercial API Implemented Google Geocoding channel feature (chadly#63) Bump version Add Google component filters for administrative areas, postal codes and countries (chadly#60) Adding Mixed SideOfStreet to MapQuest Bump minor version ahead of release Fixing space formatting Minor change Added place_id to GoogleAddress (chadly#52) update example output to match current return (chadly#54) # Conflicts: # Google/Google.csproj # Tests/MapQuestBatchGeocoderTest.cs # geocoding.nuspec # src/Geocoding.Google/GoogleGeocoder.cs # teamcity.targets # test/Geocoding.Tests/GoogleGeocoderTest.cs # test/Geocoding.Tests/MapQuestGeocoderTest.cs
|
Just validated that Bing works. |
|
Thanks @adamhathcock! I'll check this out within the next week. |
|
Thanks again @adamhathcock ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to finish off your branch for you. Can't actually test as I have no keys.
#47
I merged in master as well. Everything is Async. Hopefully, this is useful.
I need a .NET Core library so I may have to copy/paste or find something else in the short term.